use new geolookup api #1158
Open
use new geolookup api #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garmr-ulfr
force-pushed
the
group-config-req
branch
from
72db8bc
to
287ef45
Compare
anacrolix
reviewed
Oct 23, 2024
| @@ -94,6 +93,10 @@ func TestProxying(t *testing.T) { | |||
| newResult, err := Start("testapp", "en_US", testSettings{}, testSession{}) | |||
| require.NoError(t, err, "Should have been able to start lantern twice") | |||
| require.Equal(t, result.HTTPAddr, newResult.HTTPAddr, "2nd start should have resulted in the same address") | |||
|
|
|||
| // give the client time to initialize. This helps with consistency in tests | |||
| time.Sleep(1 * time.Second) | |||
There was a problem hiding this comment.
Is there something you can expose to synchronize on that will guarantee that it's initialized? Sleeping in tests is always a bad idea and the tests are already super flakey.
| @@ -160,7 +163,7 @@ func testProxiedRequest(helper *integrationtest.Helper, proxyAddr string, dnsGra | |||
|
|
|||
| var buf []byte | |||
|
|
|||
| buf, err = ioutil.ReadAll(res.Body) | |||
| buf, err = io.ReadAll(res.Body) | |||
There was a problem hiding this comment.
Can you add a sanity check to the length of the body here? Just check Response.ContentLength or whatever it's called, or add a io.LimitReader to some reasonably (large) value? Although I do see a timeout above, if it applies to body reading then it's moot.
There was a problem hiding this comment.
It think it applies to the entire request, including reading the body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The geolocation, user info, and proxy config requests in
flashlighthave been merged into a single request. The newflashlight/geolookupnow only stores the IP and country andRefreshhas been removed.This PR relies on flashlight PR and, as such, is using that branch. Once the flashlight PR is merged, this will need to be updated to use the main branch again before this can be merged.